Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

benchmark: don't stop timer until after workers are done #1407

Merged
merged 1 commit into from
Jul 31, 2017
Merged

benchmark: don't stop timer until after workers are done #1407

merged 1 commit into from
Jul 31, 2017

Conversation

dfawley
Copy link
Member

@dfawley dfawley commented Jul 31, 2017

Also, a minor change to reset the timer when the test is ready to begin instead of stopping/starting around initialization.

@dfawley dfawley requested a review from MakMukhi July 31, 2017 16:44
@dfawley dfawley merged commit 4c7bb72 into grpc:master Jul 31, 2017
@dfawley dfawley modified the milestone: 1.6 Release Aug 28, 2017
@dfawley dfawley deleted the bench_fix branch August 29, 2017 20:15
@lock lock bot locked as resolved and limited conversation to collaborators Jan 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@menghanl menghanl menghanl approved these changes

@MakMukhi MakMukhi Awaiting requested review from MakMukhi

Assignees

@MakMukhi MakMukhi

Labels
Type: Testing
Projects
None yet
Milestone
1.6 Release
Development

Successfully merging this pull request may close these issues.
3 participants
@dfawley @menghanl @MakMukhi